docs(ogc): describe actively_monitored_wells as all-groups - #874
Merged
Conversation
Contributor
Coverage✅ 79.19% total — gate is 75%. |
jirhiker
force-pushed
the
chore/actively-monitored-wells-description
branch
from
August 22, 2026 23:00
f851d8e to
cd38c00
Compare
This was referenced Aug 23, 2026
jirhiker
force-pushed
the
chore/actively-monitored-wells-description
branch
from
August 24, 2026 18:54
cd38c00 to
95577b6
Compare
Base automatically changed from
BDMS-974-a-4-fix-brittle-sql-filter-in-actively-monitored-wells
to
staging
August 24, 2026 19:38
BDMS-974 drops the "group name = 'water level network'" predicate from ogc_actively_monitored_wells, so the layer now covers currently-monitored wells in any group. The published prose still described the old filter and would have shipped wrong the moment that migration ran. The collection description now keys the layer on the monitoring status alone, and says what the join actually produces: a well in several groups appears once per group. That last point matters enough to repeat at field level -- the id column is no longer unique within the collection, which is the kind of thing a client discovers by having its keyed-by-id map silently drop rows. group_name loses its claim that it is always the Water Level Network. Keywords drop water-level-network for monitoring-status. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
likithabommasani21
force-pushed
the
chore/actively-monitored-wells-description
branch
from
August 24, 2026 19:38
95577b6 to
4cf10fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #866. Base is
BDMS-974-a-4-fix-brittle-sql-filter-in-actively-monitored-wells— one commit, three files, and it only makes sense alongside the view change in that PR.Why
#866 drops the
lower(trim(g.name)) = 'water level network'predicate, soogc_actively_monitored_wellsnow covers currently-monitored wells in any group. The layer's published prose still described the old filter:That becomes wrong the moment
986e0eb85ab3runs, and it is served to every consumer on/ogcapi/collections.What changed
group_thing_associationwithout aggregating, so a well in several groups appears once per group. Theidfield entry now says it is not unique within this collection — the kind of thing a client otherwise discovers when its keyed-by-id map silently drops rows.group_nameloses its claim that it is always the Water Level Network.water-level-networkformonitoring-status.Heads-up for #866, unrelated to this PR
There is an uncommitted migration in the shared worktree,
d4e5f6a7b8c9_cm_legacy_mirror_tables, whosedown_revisionisc3d4e5f6a7b8— the same parent as #866's986e0eb85ab3. Whoever owns that work will need to re-parent it onto986e0eb85ab3, or alembic ends up with two heads.Verification
uv run pytest tests/test_ogc.py tests/test_ogc_field_descriptions.py tests/test_ogc_field_metadata.py tests/test_pygeoapi_mount.py→ 68 passed, 1 skipped, on this branch with #866's migration applied.🤖 Generated with Claude Code